Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrated from Quick & Nimble to use XCTest to remove dependency on third party packages #213

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

desusai7
Copy link
Contributor

πŸ“‹ Changes

  • Migrated from Quick & Nimble for unit tests in this package to use XCTest to remove dependency on third party packages

βœ… Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

🎯 Testing

  • All the unit tests are successfully passing on all the platforms

@desusai7 desusai7 requested a review from a team as a code owner June 19, 2024 12:23
@desusai7 desusai7 self-assigned this Jun 19, 2024
Comment on lines 134 to 138
XCTAssertThrowsError(try sut.string(forKey: "SHOULDNOTEXIST"))
}

func testRetrievingNonExistingDataItem() {
XCTAssertThrowsError(try sut.data(forKey: "SHOULDNOTEXIST"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to assert that the error thrown is SimpleKeychainError.itemNotFound?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated it to verify if the error thrown is SimpleKeychainError.itemNotFound, please take a look again

@desusai7 desusai7 merged commit c43cd85 into master Jun 21, 2024
13 checks passed
@desusai7 desusai7 deleted the test/migrate_to_xctest branch June 21, 2024 10:06
@desusai7 desusai7 mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants